On 31/05/2024 19:51, Rémi Denis-Courmont wrote:
--- tests/checkasm/lpc.c | 57 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 55 insertions(+), 2 deletions(-)diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c index 592e34c03d..62232fdaf7 100644 --- a/tests/checkasm/lpc.c +++ b/tests/checkasm/lpc.c @@ -16,6 +16,7 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */+#include "libavutil/avassert.h"#include "libavutil/mem_internal.h"#include "libavcodec/lpc.h"@@ -57,10 +58,51 @@ static void test_window(int len) bench_new(src, len, dst1); }+#if !ARCH_X86+static void test_compute_autocorr(ptrdiff_t len, int lag) +{ + const double eps = EPS * (double)len; + LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]); + LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]); + LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]); + + declare_func(void, const double *in, ptrdiff_t len, int lag, double *out); + + av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER); + + for (int i = 0; i < MAX_LPC_ORDER; i++) + src[i] = 0.; + + src += MAX_LPC_ORDER; + + for (int i = 0; i < 5000 + 2; i++) { + src[i] = (double)rnd() / (double)UINT_MAX; + } + + call_ref(src, len, lag, dst0); + call_new(src, len, lag, dst1); + + for (size_t i = 0; i <= lag; i++) { + if (!double_near_abs_eps(dst0[i], dst1[i], eps)) { + fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n", + i, dst0[i], dst1[i], dst0[i] - dst1[i]); + fail(); + break; + } + } + + bench_new(src, 4608, lag, dst1); +} +#endif + void checkasm_check_lpc(void) { LPCContext ctx; - int len = rnd() % 5000; + int len = 2000 + rnd() % 3000;
Please don't randomize the length in tests. Pick a few lengths to check all corner cases. Checkasm tests should be deterministic in how long it takes to run them between invocations.
+#if !ARCH_X86 + static const int lags[] = { 8, 12, }; +#endif + ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) {@@ -72,6 +114,17 @@ void checkasm_check_lpc(void) test_window(len | 1); } report("apply_welch_window_odd"); - ff_lpc_end(&ctx); + +#if !ARCH_X86 + for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) { + ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT); + if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i])) { + test_compute_autocorr(len & ~1, lags[i]); + test_compute_autocorr(len | 1, lags[i]); + } + ff_lpc_end(&ctx); + } + report("compute_autocorr"); +#endif }
OpenPGP_0xA2FEA5F03F034464.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
