Hi James On Wed, Apr 08, 2026 at 08:54:58PM -0700, James Zern via ffmpeg-devel wrote: > On Wed, Apr 8, 2026 at 6:57 PM Michael Niedermayer via ffmpeg-devel > <[email protected]> wrote: > > > > Hi all > > > > ive written a script to approve pull requests for which the following is > > true: > > 1. no activity for one week > > 2. CI passes > > 3. no outstanding change requests > > 4. not marked as WIP > > 5. pull request is open > > > > The goal is to reduce the pain and friction to get things applied > > Are there additional requirements i should add ? > > > > Something like https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21788 which > has an open comment about holding the patch until an external > condition is met (spec is finalized). To block merging that, should a > change request have been filed?
First. The script in its current form _approves_ pull requests. That would only result in them to be merged if either the PR is marked as auto-merge or if someone (with the needed permissions) clicks that button so actually, nothing would need to be done. It would approve but not merge it But if one wanted to be explicit about this then maybe marking it as WIP is semantically more correct than a change request because there is no request for a change but it is work in progress that will be finished once the spec text is final and also the implementation matches that final text. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothing to hide" only works if the folks in power share the values of you and everyone you know entirely and always will -- Tom Scott
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
