On Thu, Apr 09, 2026 at 03:44:09PM +0200, Timo Rothenpieler via ffmpeg-devel wrote: > On 09/04/2026 06:19, Gyan Doshi via ffmpeg-devel wrote: > > > > > > On 2026-04-09 07:26 am, Michael Niedermayer via ffmpeg-devel wrote: > > > Hi all > > > > > > ive written a script to approve pull requests for which the > > > following is true: > > > 1. no activity for one week > > > 2. CI passes > > > 3. no outstanding change requests > > > 4. not marked as WIP > > > 5. pull request is open > > > > > > The goal is to reduce the pain and friction to get things applied > > > Are there additional requirements i should add ? > > > > 6. Patch author is either CODEOWNER of touched files or has existing > > commits merged in touched files. > > In the MAINTAINERS file, anyone can write themselves into CODEOWNERS to be > tagged for reviews. It says nothing about actual ownership, despite its > name.
teh MAINTAINERS file is not using forgejo user names it also doesnt use precisse regex expressions also it would defeat the intend the intend is to reduce friction. If i open a PR that fixes a security issue and mark it as auto merge. A month later i realize it has been forgotten noone reviewed, noone approved and on top i cant even click "merge" i need to manually 1. fetch 2 remote branches 2. rebase one 3. run tests locally 4. push 2 branches in the right order Iam not in MAINTAINERs for the whole codebase also I think if the whole team ignores a patch that is marked as auto-merge for a week. the action of it going in cant really be a surprise for anyone ;) if its not marked as auto merge than the script approving it wont merge it but as said, i intend to be cautious with this at first and try it slowly. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Some people wanted to paint the bikeshed green, some blue and some pink. People argued and fought, when they finally agreed, only rust was left.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
