PR #25624 opened by bkuhls URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/25624 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/25624.patch
# Summary of changes https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/471db1d323aaed50ff922f0da76ecc8e45c4e817 added armv6 optimizations and guarded the include with ``` #elif ARCH_ARM && HAVE_ARMV6 ``` but guarded the code only with ``` #elif ARCH_ARM ``` causing a build error with armv5 toolchains: ``` libavutil/pixelutils.c: In function ‘av_pixelutils_get_sad_fn’: libavutil/pixelutils.c:102:5: error: implicit declaration of function ‘ff_pixelutils_sad_init_arm’ [-Wimplicit-function-declaration] ``` Signed-off-by: Bernd Kuhls <[email protected]> From 762fdecf7a151f2cfaa5a5ff3a41344ca531fbe5 Mon Sep 17 00:00:00 2001 From: Bernd Kuhls <[email protected]> Date: Fri, 30 Oct 2026 08:52:16 +0100 Subject: [PATCH] avutil/arm: fix armv5 build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/471db1d323aaed50ff922f0da76ecc8e45c4e817 added armv6 optimizations and guarded the include with #elif ARCH_ARM && HAVE_ARMV6 but guarded the code only with #elif ARCH_ARM causing a build error with armv5 toolchains: libavutil/pixelutils.c: In function ‘av_pixelutils_get_sad_fn’: libavutil/pixelutils.c:102:5: error: implicit declaration of function ‘ff_pixelutils_sad_init_arm’ [-Wimplicit-function-declaration] Signed-off-by: Bernd Kuhls <[email protected]> --- libavutil/pixelutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/pixelutils.c b/libavutil/pixelutils.c index 869af809eb5..e99334ae838 100644 --- a/libavutil/pixelutils.c +++ b/libavutil/pixelutils.c @@ -98,7 +98,7 @@ av_pixelutils_sad_fn av_pixelutils_get_sad_fn(int w_bits, int h_bits, int aligne #if ARCH_AARCH64 && HAVE_NEON ff_pixelutils_sad_init_aarch64(sad, aligned); -#elif ARCH_ARM +#elif ARCH_ARM && HAVE_ARMV6 ff_pixelutils_sad_init_arm(sad, aligned); #elif ARCH_MIPS && HAVE_MSA ff_pixelutils_sad_init_mips(sad, aligned); -- 2.54.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
