On Sun, Nov 29, 2015 at 7:45 AM, Paul B Mahol <one...@gmail.com> wrote: > On 11/29/15, Ganesh Ajjanagadde <gajja...@mit.edu> wrote: >> On Sat, Nov 28, 2015 at 6:21 PM, Ganesh Ajjanagadde <gajja...@mit.edu> >> wrote: >>> On Sat, Nov 28, 2015 at 5:26 PM, Paul B Mahol <one...@gmail.com> wrote: >>>> Signed-off-by: Paul B Mahol <one...@gmail.com> >>> [...] >>> >>>> + case SQUARE: >>>> + val = (phs < 0.5) ? -1 : +1; >>> >>> Something I missed: consider using e.g FFSIGN(phs - 0.5) or FFSIGN(0.5 >>> - phase), can't recall. >> >> This I still suggest for readability. > > Both produce differend md5 output.
May have to do with underflow, i.e numbers near 0.5. Anyway, if you care about branchless code here, it may be worthwhile to test since it is just the sign bit of the result. But it should not be worth it for the first patch, especially since you seem to care about bit-exact output with some reference point. [...] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
