On Fri, Mar 04, 2016 at 11:24:00AM -0500, Ronald S. Bultje wrote: > Hi, > > On Wed, Mar 2, 2016 at 4:11 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > > > Hi, > > > > On Wed, Mar 2, 2016 at 3:51 PM, wm4 <nfx...@googlemail.com> wrote: > > > >> On Wed, 2 Mar 2016 15:48:11 -0500 > >> "Ronald S. Bultje" <rsbul...@gmail.com> wrote: > >> > >> > Hi, > >> > > >> > On Mon, Feb 29, 2016 at 10:32 AM, Ronald S. Bultje <rsbul...@gmail.com> > >> > wrote: > >> > > >> > > If pkt->size == 0 && pkt->side_data_elems == 0 after bsf->filter() > >> > > returns, the packet is considered dropped. > >> > > >> > > >> > Ping? > >> > > >> > >> (Personally I'm not so fond of such subtle API changes, also doesn't > >> Libav's glorious new BSF API cover this?) > > > > > > Possibly, but it's not in yet, is it? > > > > (We can revert this piece of code when their new API lands.) > > > > Ping again?
the only thing on this patch set that gives me a slightly odd feeling is that the droped case overlaps with a case that can be stored in files, that is packets with size 0 otherwise patch LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
