On Thu, Aug 24, 2017 at 10:36:20AM +0200, Kv Pham wrote: > Yes I did a make fate. Went ok. > Is there a log to attach ? Or stdout ?
i meant can you add a test that tests the new feature when one runs make fate that is if the user runs "make fate" it would execute ffmpeg with map and "trailing ?" > > > Le 24 août 2017 10:34 AM, "Michael Niedermayer" <mich...@niedermayer.cc> a > écrit : > > On Thu, Aug 24, 2017 at 08:17:58AM +0200, pkv.stream wrote: > > Le 24/08/2017 à 2:30 AM, Michael Niedermayer a écrit : > > >On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: > > >>Hello, > > >> > > >>the following patch allows one to add a trailing ? to -map_channel > > >>as in -map option. > > >> > > >>E.g: -map_channel 0.0.2? so that if the channel does not exist, the > > >>command does not stop. > > >> > > >>This is similar to what one can do with -map. > > >> > > >>Thanks for any input. > > >> > > >> > > >> ffmpeg_opt.c | 24 ++++++++++++++++++++---- > > >> 1 file changed, 20 insertions(+), 4 deletions(-) > > >>28689933986d73050286e700752ace032df6dc1b 0001-ffmpeg-options-Enable- > trailing-for-map_channel.patch > > >> From 07959dfe79816d03c30b8027f45b41d60078b3fa Mon Sep 17 00:00:00 2001 > > >>From: pkviet <pkv.str...@gmail.com> > > >>Date: Tue, 22 Aug 2017 11:30:45 +0200 > > >>Subject: [PATCH] ffmpeg options: Enable trailing ? for map_channel > > >> > > >>The -map option allows for a trailing ? so that an error is not thrown > if > > >>the input stream does not exist. > > >>This capability is extended to the map_channel option. > > >>This allows a ffmpeg command not to break if an input channel does not > > >>exist, which can be of use (for instance, scripts processing audio > > >>channels with sources having unset number of audio channels). > > >>--- > > >> ffmpeg_opt.c | 24 ++++++++++++++++++++---- > > >> 1 file changed, 20 insertions(+), 4 deletions(-) > > >the patch contains tabs (cannot be pushed to git master) > > >and this is missing an update to the documentation > > > > thanks Michael. > > Patch corrected per your instructions. > > Updated doc , provided an example and removed all tabs ! > > ok, thanks > can you also add a self test to "make fate" ? > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Let us carefully observe those good qualities wherein our enemies excel us > and endeavor to excel them, by avoiding what is faulty, and imitating what > is excellent in them. -- Plutarch > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matters, not just one of them.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel