Thanks a lot Michael. (and for spotting the avfree I missed) Le 25 août 2017 11:44 PM, "Michael Niedermayer" <mich...@niedermayer.cc> a écrit :
On Thu, Aug 24, 2017 at 11:10:49PM +0200, pkv.stream wrote: > Thanks a lot Martin !!! all sorted out thanks to your kind help. > I had run fate previously but obviously missed something; so re-run > and it's ok. > > I created two tests per your advice testing for a third channel in a > stereo file and then in a 2.1 file. > Instead of CRC, I've used MD5 because the extant mapchan fate tests > were using it. > > Updated patch in attachment. > > Michael: would that be OK or do you see other changes to make ? > > > > doc/ffmpeg.texi | 13 +++++++++++- > ffmpeg_opt.c | 21 +++++++++++++++++--- > tests/fate/ffmpeg.mak | 8 +++++++ > tests/ref/fate/mapchan-2ch-extract-ch0-ch2-trailing | 1 > tests/ref/fate/mapchan-3ch-extract-ch0-ch2-trailing | 1 > 5 files changed, 40 insertions(+), 4 deletions(-) > 1d35047c00f25dc1391a541eb704a03a9c9198de 0001-ffmpeg-options-Enable- trailing-for-map_channel.patch > From 5c3b0fed39b713b19ed53b5704b1fce63b2742ad Mon Sep 17 00:00:00 2001 > From: pkviet <pkv.str...@gmail.com> > Date: Tue, 22 Aug 2017 11:30:45 +0200 > Subject: [PATCH] ffmpeg options: Enable trailing ? for map_channel > > The -map option allows for a trailing ? so that an error is not thrown if > the input stream does not exist. > This capability is extended to the map_channel option. > This allows a ffmpeg command not to break if an input channel does not > exist, which can be of use (for instance, scripts processing audio > channels with sources having unset number of audio channels). added missing av_free() applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel