> On 2019-03-26 21:22, Mike Stoner via ffmpeg-devel wrote: > > > Hello, > > I’ve accounted for all feedback on this so far, I’m wondering if it is > > ready to be pushed upstream? > > > > Here are my results from ‘checkasm’ (lower is better): > > > > v210_unpack_c: 1636 > > v210_unpack_ssse3: 611 > > v210_unpack_avx: 601 > > v210_unpack_avx2: 423 > > > > I ran it 5 times and averaged the middle 3 results for each CPU target > > (ignoring the highest and lowest time). > > > > https://patchwork.ffmpeg.org/patch/12325/ > > > > > > Thanks… -Mike > > > Sorry that I keep forgetting about this. I will try to make some time > tomorrow to give this another look over. > > I'm not sure what order this and my checkasm patch should be applied in, > which I also forgot about. > > Did anyone else make comments on either patch? >
Martin Vignali had commented about using VBROADCASTI128 instead of doubling the constants to 32 bytes for AVX2. I incorporated that into the updated patch. Your checkasm patch looks good to me. I think you could also add it to "/tests/fate/checkasm.mak". I'm open to either order that these could be committed. Note there are already a few Fate vsynth tests that will fail if v210dec gets broken. -Mike _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
