Hi,
> > The difference? > > In addition to a few extra little checks, It seems that the > > QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) check fails every time in > > Windows (almost in my environment). > > If QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) always equal to zero, then co3 > won't be set, > If codec is MPEG2, co3 won't be set too. > I can't see any difference for MPEG2 case. Your assumption about QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) is not real. This depends on the run-time driver used. > > Futhermore, it has more sense to apply the check inside the conditional > > preprocessing of #if QSV_HAVE_CO3 and not outside. > > Make sense, but no difference for run-time result? I prefer to make the code as more legible as possible. That's the reason for the other additions of #if QSV_HAVE_CO3. > > As a summary: I confirm that my patch works. And it's based on your > > proposal. So please comment positively to merge it. > > It is closer to be merged, but need to confirm which exact line of code make > difference. > (Your verification on Windows was appreciated.) As I pointed, the QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) check fails in Windows. This version runs without problems and resolves the bug (in Windows). So, I suggest to accept this patch. Regards. A.H. --- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
