> > > > > > It is closer to be merged, but need to confirm which exact line of code > > > make difference. > > > (Your verification on Windows was appreciated.) > > > > As I pointed, the QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) check fails > > in Windows. > > This version runs without problems and resolves the bug (in Windows). > > Well, let me to explain with more detail: > > V1: > if (avctx->codec_id != AV_CODEC_ID_MPEG2VIDEO && > > > QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11)) > > For mpeg2 case, it is always equal to "if (0)" , right? > > V2: > if (avctx->codec_id != AV_CODEC_ID_MPEG2VIDEO) > > For mpeg2 case, it is equal to "if (0)" too, right? > > Thus why I asked what the difference between V1 and V2 was.
I'm sorry! Now I understand what you're saying. It's my fault. Well then... I feel like you're right. However, I can only comment that the first time I compiled your patch it doesn't work. And for this reason I created this one. And now I can confirm that it resolves the problem. Please feel free to approve whatever you think is best. But something has to be done, because the MPEG-2 QSV encoder in Windows is broken. Regards. A.H. --- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".