On 6/27/2019 9:59 AM, Zhong Li wrote: > Signed-off-by: Zhong Li <zhong...@intel.com> > --- > libavcodec/mjpeg_parser.c | 158 > +++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 157 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mjpeg_parser.c b/libavcodec/mjpeg_parser.c > index 07a6b2b..f59aa3e 100644 > --- a/libavcodec/mjpeg_parser.c > +++ b/libavcodec/mjpeg_parser.c > @@ -27,12 +27,131 @@ > */ > > #include "parser.h" > +#include "mjpeg.h" > +#include "mjpegdec.h" > +#include "get_bits.h" > > typedef struct MJPEGParserContext{ > ParseContext pc; > + MJpegDecodeContext dec_ctx;
This is not acceptable. The parser shouldn't use decoder structs, as it makes the former depend on the latter. A reusable header parsing function should be standalone, so it may be called from decoders, parsers, bitstream filters, and anything that may require it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".