On 07/15/2010 12:18 AM, Sebastian Vater wrote:
Vitor Sessak a écrit :
Changing a little bit the subject, I suggest that after you take into
account all the feedback you had, you send a new patchset, this time
containing just the headers for the BSS (and _only_ the BSS, without a
single code line or define that belongs to the player!), so we can
give a second round of reviewing.
So here is it, I merged them all into one to avoid flooding the ML.
They're getting small enough now, to merge them all into one, I think!
This is not a patch against latest SVN, this is a patch against your SoC
tree and thus unreadable (your patch should contain all the lines of
libavsequencer/* since none of this files exists now in main svn).
diff --git a/libavsequencer/track.h b/libavsequencer/track.h
index c1370ed..33095d9 100755
--- a/libavsequencer/track.h
+++ b/libavsequencer/track.h
@@ -34,12 +34,18 @@
* version bump.
*/
[...]
/** 0x20 - Set volume:
Again, is saying "0x20" in the comment relevant? If this value for the
set volume command is format-dependent (i.e., it is only 0x20 in MOD but
0x55 in XM), this is misleading.
Data word consists of two 8-bit pairs named xx and yy
where xx is the volume level (ranging either from
@@ -756,7 +729,8 @@ typedef struct AVSequencerTrackEffect {
means that the tremolo envelope values will be inverted. */
#define AVSEQ_TRACK_EFFECT_CMD_T_TREMO_ONCE 0x2F
Wasn't you going to change these (and many other) to a enum? I remember
you said you would change it soon, but being afraid of breaking other
files that uses this header, but what code exactly does replacing
#define AVSEQ_TRACK_EFFECT_CMD_T_TREMO_ONCE 0x2F
#define AVSEQ_TRACK_EFFECT_CMD_STOP_FX 0x1D
by
enum Whatever {
AVSEQ_TRACK_EFFECT_CMD_T_TREMO_ONCE = 0x2F,
AVSEQ_TRACK_EFFECT_CMD_STOP_FX = 0x1D,
}
breaks?
-Vitor
_______________________________________________
FFmpeg-soc mailing list
[email protected]
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-soc
