On Sat, Nov 15, 2003 at 03:58:01AM -0800, Max Horn wrote:
> disable not working test
Tests are there to tell you something might be broken. If you just comment
it out when it starts failing then the tests are worthless.
You don't disable a failing test. You either fix the bug, fix the test or
post a bug report and set TODO (see t/Command/failure.t for examples).
Here's the analysis.
A simple check of the ChangeLog shows that get_perl_dir_arch() was
changed recently.
2003-11-13 Dave Morrison <[EMAIL PROTECTED]>
* PkgVersion.pm: Revise get_perl_dir_arch() and the places where it
is used, correcting some errors in UpdatePOD in case of Type: perl,
and guaranteeing that the correct perl command is used when needed.
An additional return value was added and the internal logic changed. Now
it figures out its perl info from the file's "Type" argument. I used
sed's .info file in the test but that isn't going to work anymore since
it doesn't have Type: perl. It doesn't look like a bug, but that the test
made an assumption that's no longer true. So the test has to be fixed by
replacing sed's .info file with a perl one. I'll pick something simple.
mp3-info-pm-1.01-1.info has "Type: perl".
Plop that in, rerun the tests and... still broken. No version
returned. This is a new behavior. Was it intentional? I dunno.
get_perl_arch_dir() has no docs.
Dave? What should the behavior of get_perl_arch_dir when Type is "perl"
with no version?
> --- get_perl.t 12 Nov 2003 04:08:12 -0000 1.2
> +++ get_perl.t 15 Nov 2003 11:57:59 -0000 1.3
> @@ -16,7 +16,7 @@
> isa_ok( $pv, 'Fink::PkgVersion' );
>
> my($perldir, $perlarch) = $pv->get_perl_dir_arch;
> -like( $perldir, qr{^/ 5 \. \d{1,2} \. \d{1,2} $}x );
> +#like( $perldir, qr{^/ 5 \. \d{1,2} \. \d{1,2} $}x );
> like( $perlarch, qr{^darwin} );
> unlike( $perlarch, qr{[='"]}, 'not picking up extra cruft from -V' );
> unlike( $perlarch, qr/\n/, 'no stray newlines in perlarch' );
--
Michael G Schwern [EMAIL PROTECTED] http://www.pobox.com/~schwern/
WOOHOO! I'm going to Disneyland!
http://www.goats.com/archive/980805.html
-------------------------------------------------------
This SF. Net email is sponsored by: GoToMyPC
GoToMyPC is the fast, easy and secure way to access your computer from
any Web browser or wireless device. Click here to Try it Free!
https://www.gotomypc.com/tr/OSDN/AW/Q4_2003/t/g22lp?Target=mm/g22lp.tmpl
_______________________________________________
Fink-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/fink-devel
