Some thoughts on patch #5: Our .deb repository is built with %p=/sw. If that is not how a user has configured his fink, even a .deb present in apt-cache is not usable.
In PkgVersion::apt_fetch, you appear to download the .deb to $basepath/fink/debs. Is our apt-get hacked to know to look there, does one have to first run "scanpackages" or some such? Reason I ask is that it feels confusing that one would use fink "to download the .deb from the apt repository" but then apt doesn't automatically see it. Also, that means you're mixing downloaded and locally-built .deb. That could make it hard to debug user problems, since one could not determine whose .deb-building broke. Would be better to download to apt's location? Also in that method, you first try to download the .deb, and then if that fails you symlink the one in apt's location. Why not look for the already-downloaded file first, and only download if it's not already present? The symlink call needs some error checking. But why symlink at all, given that you also hack PkgVersion::find_debfile to look in apt's cache? That find_debfile check for an apt .deb should only happen if user sets --use-binary-dist. dan -- Daniel Macks [EMAIL PROTECTED] http://www.netspace.org/~dmacks ------------------------------------------------------- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php _______________________________________________ Fink-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/fink-devel
