Thanks for lots of comments!
I attach a new patch for gimp2.info.

Additional changes:

* Depends:
 - depends libgtkhtml2 with the version clause (>= 2.6.4-1013).
* ConfigureParams:
 - Add --without-poppler.

At Wed, 30 Apr 2008 09:18:40 -0400,
Daniel Macks wrote:
> 
> Looks functionally nearly the same as the one I have locally for it.
> Two issues:
> 
> 1. The dependency on libgtkhtml2 needs to be versioned (to the one I
> committed to pangocairo a day or so ago).
> 
I added the version clause (>= 2.6.4-1013). Is it ok?

> 2. ./configure auto-detects poppler, so it needs pooppler2 &
> poppler2-glib as BuildDepends (and their -shlibs as Depends in
> %N-shlibs).
> 
The original finkinfo use ghostscript, not poppler, and splitoff
%N-ghostscript. I'd like to follow the packaging way.
So I added --without-poppler to ConfigureParams.

> One question: in InstallScript:
> 
> - (cd ../gimp-help-2-0.5; make install DESTDIR=%d) || exit 1
> + (cd ../gimp-help-2.4.1; make install DESTDIR=%d top_builddir=`pwd`) || exit 
> 1
> 
> I've never seen an explicit top_builddir needed before. Any idea what
> is happening here?
> 
If top_builddir is not specified, the following error occurs in my env:

(cd ../gimp-help-2.4.1; make install 
DESTDIR=/sw/src/fink.build/root-gimp2-2.4.5-1) || exit 1
Making install in quickreference
make[2]: Nothing to be done for `install-exec-am'.
make[2]: Nothing to be done for `install-data-am'.
make[2]: Nothing to be done for `install-exec-am'.
././install-sh -c -d /sw/src/fink.build/gimp2-2.4.5-1/sw/share/gimp/2.0/help
** Installing HTML:/bin/sh: ././install-sh: No such file or directory

Any other ideas for avoiding it?

At Wed, 30 Apr 2008 10:51:11 -0400,
Benjamin Reed wrote:
> 
> Daniel Macks wrote:
> 
> |>  - Add --disable-python.
> 
> | Looks functionally nearly the same as the one I have locally for it.
> | Two issues:
> 
> Also, why disable python?
> 
If enable python, some messy changes should be done, and lots of
dependency should be added, which may be painful for the maintainer
and users.
My patch changes gimp2.info as little as possible from the original one.

At Wed, 30 Apr 2008 10:59:11 -0400,
Alexander Strange wrote:
> 
> There's another new package for it here:
> http://sourceforge.net/tracker/index.php?func=detail&aid=1942780&group_id=17203&atid=414256
> 
> For some reason I can't find the start of this thread in gmane or my  
> inbox, so I can't compare them.
> 
As noted above, my patch follows your original packaging way.
Another one seems to make some big changes in packaging.
It's difficult for me to say which is better.
Which one do you like?

Thanks,
Tomoaki Okayama

Attachment: gimp2_update_pangocairo_2.diff
Description: Binary data

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Fink-devel mailing list
Fink-devel@lists.sourceforge.net
http://news.gmane.org/gmane.os.apple.fink.devel

Reply via email to