On Wed, May 21, 2008 at 03:53:59AM +0200, Jean-Fran?ois Mertens wrote: > Martin, > > Could you please have a look at pwlib1 on 10.5 ? > I'm committing now, thanks to your msg, a small > additional item, that should fix Alexander's psetgrp issue > on 10.5 w/o change on 10.4. > > There is an additional (10.5) possible issue about semaphores, > apparently implicitly raised in a "patch file" attached > to a "bug report" (#1961744). The submitter doesn't > even specify what problem the patch is trying to fix, > _ even just, if it is a build problem, as I think is meant, > the compile command and corresponding error msg... > A fortiori there is no analysis whatsoever... > (And further, I don't trust his system, since you > showed me his "cp" command gave non-standard output...) > > It just implies that he thinks that on his system the equivalent > of an additional line in the patchscript like (exactly) : > > sed -ri.bak -e '/SEM_FAILED/s,\(int\),,' src/ptlib/unix/tlibthrd.cxx > > might _ help ? be usefull ? be needed ?? > > The whole thing concerns lines 1548 to 1568 in src/ptlib/unix/ > tlibthrd.cxx > (and /usr/include/sys/semaphore.h ).
Could this pile of sed patchscript be converted into an actual .patch file? That way one doesn't have to learn sed (and install fink's sed!) to understand what's happening here. As a bonus, if the source changes in future versions, either the patch will continue to work or it will fail loudly, whereas a script full of regexp- or line-number-based changes may simply and silently do "something different". dan -- Daniel Macks [EMAIL PROTECTED] http://www.netspace.org/~dmacks ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Fink-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fink-users
