On 4-7-2014 16:23, Roman Simakov wrote: > Hello! > > I'd like to present a patch for firebird trunk which implements > http://tracker.firebirdsql.org/browse/CORE-735 like Red Database does. > > Patch was discussed with Dmitry Yemanov, Alex Peshkoff and Vlad Khorsun. > Small description you can find in doc/sql.extensions/README.ddl_access.txt > > I'm ready to answer any questions. > > I'd like to commit it. Opinions?
I have not checked the code thoroughly, but I noticed two things: 1) there are still some TODOs in the code 2) the new error codes are mapped to SQL state 00000 (success) For 2 (entirely based on the name), I'd propose: * dyn_no_priv (335545094): 42000 (syntax error or access rule violation) * dsql_cant_grant_option (336397330) : 42000 (syntax error or access rule violation), I had hoped there was a closer one, but there doesn't appear to be. Mark -- Mark Rotteveel ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
