Hi, Mark!
Thanks for your reply:
2014-07-05 10:30 GMT+04:00 Mark Rotteveel <m...@lawinegevaar.nl>:
> I have not checked the code thoroughly, but I noticed two things:
> 1) there are still some TODOs in the code
Yes. The main part is done. The rest one is about user management
which will be implemented a bit later with Alex help. In the same time
this patch could be tested right now.
> 2) the new error codes are mapped to SQL state 00000 (success)
How about this?
diff --git a/src/msgs/messages2.sql b/src/msgs/messages2.sql
index e7fc5e0..80f18a3 100644
--- a/src/msgs/messages2.sql
+++ b/src/msgs/messages2.sql
@@ -881,6 +881,8 @@ Data source : @4', NULL, NULL)
('set_invalid_role', 'SetRoleNode::execute', 'StmtNodes.cpp', NULL,
0, 771, NULL, 'Role @1 is invalid or unavailable', NULL, NULL);
('cursor_not_positioned', NULL, NULL, NULL, 0, 772, NULL, 'Cursor @1
is not positioned in a valid record', NULL, NULL);
('dup_attribute', 'UserManagement::execute', 'UserManagement.cpp',
NULL, 0, 773, NULL, 'Duplicated user attribute @1', NULL, NULL);
+('dyn_no_priv', NULL, 'dyn_*.epp', NULL, 0, 774, NULL, 'There is no
privilege for this operation', NULL, NULL);
+('dsql_cant_grant_option', 'getMainErrorCode', 'DdlNodes.h', NULL, 0,
775, NULL, 'Using GRANT OPTION on @1 not allowed', NULL, NULL);
-- QLI
(NULL, NULL, NULL, NULL, 1, 0, NULL, 'expected type', NULL, NULL);
(NULL, NULL, NULL, NULL, 1, 1, NULL, 'bad block type', NULL, NULL);
diff --git a/src/msgs/system_errors2.sql b/src/msgs/system_errors2.sql
index d10471a..3112b20 100644
--- a/src/msgs/system_errors2.sql
+++ b/src/msgs/system_errors2.sql
@@ -780,6 +780,8 @@ set bulk_insert INSERT INTO SYSTEM_ERRORS
(SQL_CODE, SQL_CLASS, SQL_SUBCLASS, FA
(-901, '0P', '000', 0, 771, 'set_invalid_role', NULL, NULL);
(-596, 'HY', '109', 0, 772, 'cursor_not_positioned', NULL, NULL)
(-901, '42', '702', 0, 773, 'dup_attribute', NULL, NULL);
+(-901, '42', '000', 0, 774, 'dyn_no_priv', NULL, NULL)
+(-901, '42', '000', 0, 775, 'dsql_cant_grant_option', NULL, NULL);
-- GFIX
(-901, '00', '000', 3, 1, 'gfix_db_name', NULL, NULL)
(-901, '00', '000', 3, 2, 'gfix_invalid_sw', NULL, NULL)
--
Roman Simakov
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
Firebird-Devel mailing list, web interface at
https://lists.sourceforge.net/lists/listinfo/firebird-devel
