On 4-9-2019 11:39, Vlad Khorsun wrote:
04.09.2019 9:50, Mark Rotteveel wrote:
On 3-9-2019 08:35, Vlad Khorsun wrote:
03.09.2019 4:32, Adriano dos Santos Fernandes wrote:
On 02/09/2019 06:26, Alex Peshkoff via Firebird-devel wrote:


If even this causes problems offset may be displayed instead, i.e.
GMT+3. That's definitely trivial.


Fallback for the crazy situation of wrong client (without ICU) is

   Not agree, this is not a "crazy situation". ICU was included into Win10 not so long ago. And there is a lot of machines with older Windows running.

already present: display gmt time with region "GMT*".

   This is ugly hack, not a fallback. I prefer to remove it from the codebase.

It is a fallback. And it is better than presenting the client with an error.

  Smart client (even not too smart, btw) always check for errors. In this thread we trying to offer a ways to handle such errors gracefully. Client should not be
forced to check result string for "GMT*" - this is ugly, sorry.

I don't really like the inclusion of the * in GMT*, but I can live with it.

   My opinion not changed - it is a hack, very ugly hack.

I agree it is a hack. Just using GMT with the * should be enough.

Nobody need GMT time when asking for regional one.
Error conditios should be reported via status-vector, for "light" errors we
have warnings.

It is a client-side rendering of time, not something that went wrong on the server.

  Error is error, doesn't matter where it happens. Or you could offer "fallback" for wrong database handle\wrong server name in isc_attach_database\not working client DNS\etc
cases ?

There is a difference between something that **cannot work**, and something that has a reasonable fallback. Presenting the time in GMT when the timezone cannot be correctly derived, is still intelligible by a user, and it is a form of a graceful degradation compared to just throwing an error in the face of the user and basically telling them "fuck you".

Especially as I will guess that the consumer of this functionality is probably only ISQL.

Mark
--
Mark Rotteveel


Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to