I uploaded 1.19.0 to Debian this weekend (yeah, I've been lazy) and noticed some a build failure[0] on ia64.
Running fish_tests during "make test" segfaulted with the following
backtrace:
(gdb) bt
#0 0x4000000000069040 in hash_wcs_func (data=0x140f0) at util.c:506
#1 0x4000000000066a80 in hash_search (h=0x60000000000149a0, key=0x140f0) at
util.c:222
#2 0x4000000000067470 in hash_put (h=0x60000000000149a0, key=0x140f0,
data=0x60000000000140d0)
at util.c:294
#3 0x4000000000029e20 in env_set (key=0x60000000000140a0,
val=0x60000000000140b4, var_mode=6)
at env.c:649
#4 0x4000000000028280 in env_init () at env.c:336
#5 0x4000000000093720 in main (argc=1, argv=0x60000fffff95bc68) at
fish_tests.c:680
Notice that the key being passed to env_set (0x60000000000140a0) is
truncated when it's used in the hash_put call (0x140f0).
The same backtrace occurs when starting up fish, as expected, since this
is during env_init.
I'd also like to point out that there are a number of files[1] with "implicit
declaration of function ..." warnings. I'll be glad to help check for
stuff like this before releases, but I'd also recommend a stricter
pre-release build process. Maybe adding a 'debug' rule to the Makefile
that adds the following CFLAGS: -O0 -Wno-unused -Werror -g
I just tested the latest Darcs tree and these problems seem to be fixed,
but I think it should be a goal to not have out-of-the-box build
failures of a fresh release and I'm willing to do what I can to help out
with that. The recent Darcs tree also seems to have the fewest pointer
<-> int conversion warnings I've seen. :) Looks like things are
working themselves out.
On another note, there's a slight typo in INSTALL which I've attached a
patch for.
James
[0]:
http://buildd.debian.org/fetch.php?&pkg=fish&ver=1.19.0-1&arch=ia64&stamp=1137360052&file=log&as=raw
[1]: builtin.c:1116: warning: implicit declaration of function 'wcsdup'
builtin.c:1134: warning: implicit declaration of function 'wcscasecmp'
builtin_set.c:132: warning: implicit declaration of function 'wcsdup'
common.c:984: warning: implicit declaration of function 'wcsdup'
complete.c:395: warning: implicit declaration of function 'wcsdup'
env.c:561: warning: implicit declaration of function 'wcsdup'
event.c:137: warning: implicit declaration of function 'wcsdup'
expand.c:141: warning: implicit declaration of function 'wcsdup'
function.c:76: warning: implicit declaration of function 'wcsdup'
highlight.c:134: warning: implicit declaration of function 'wcsdup'
history.c:142: warning: implicit declaration of function 'wcsdup'
input.c:280: warning: implicit declaration of function 'wcsdup'
input.c:496: warning: implicit declaration of function 'wcsncasecmp'
intern.c:59: warning: implicit declaration of function 'wcsdup'
kill.c:72: warning: implicit declaration of function 'wcsdup'
output.c:401: warning: implicit declaration of function 'wcscasecmp'
parser.c:540: warning: implicit declaration of function 'wcsdup'
reader.c:1382: warning: implicit declaration of function 'wcsdup'
signal.c:247: warning: implicit declaration of function 'wcsncasecmp'
signal.c:250: warning: implicit declaration of function 'wcscasecmp'
tokenizer.c:148: warning: implicit declaration of function 'wcsdup'
wildcard.c:148: warning: implicit declaration of function 'wcsdup'
--
GPG Key: 1024D/61326D40 2003-09-02 James Vega <[EMAIL PROTECTED]>
New patches:
[INSTALL: Fix a small typo in the darcs-tree build procedure.
James Vega <[EMAIL PROTECTED]>**20060116025621] {
hunk ./INSTALL 36
-If you have downloaded the darcs repository of fish, you need to sun
+If you have downloaded the darcs repository of fish, you need to run
}
Context:
[Minor completion tweaks
[EMAIL PROTECTED]
[Make the functions builtin display function listing on -n to a terminal in a
human-friendly format
[EMAIL PROTECTED]
[Make the completions for the ls, sed and df commands have the correct switches
on BSD systems
[EMAIL PROTECTED]
[Minor polish to the gpg completions
[EMAIL PROTECTED]
[Various corrections for advanced tab completions. Should make the --export=
subcompletions to gpg work
[EMAIL PROTECTED]
[Make sure functions as printed by the fyunctions builtin don't have any stray
empty lines
[EMAIL PROTECTED]
[Add completions for gpg command
[EMAIL PROTECTED]
[Add completions for chsh command (updated)
[EMAIL PROTECTED]
[Fix the __fish_append shellscript function, as well as some completion bugs in
gpg and mount
[EMAIL PROTECTED]
[Correctly handle locale changes through scope expiry, as well as locale
changes in completion code
[EMAIL PROTECTED]
[Minor completion description corrections - unescaped dollar-signs in quotes
and such
[EMAIL PROTECTED]
[Alt-backspace is now a synonym for Control-w in emacs mode keybindings. Atl
least on terminals with a simple Alt-backspace
[EMAIL PROTECTED]
[Improve description handling - handle symbolic link loops, handle description
functions returning strings without a separator, and handle testing of
un-stat:able files
[EMAIL PROTECTED]
[Make parser_current_line use dynamic memory to avoid overflow on long lines
[EMAIL PROTECTED]
[Add one missing translation string in exec.c
[EMAIL PROTECTED]
[Recover instead of quiting when a redirection error occurs for a shellscript
function
[EMAIL PROTECTED]
[Use /etc/sysconfig/i18n file if it exists to set up correct locale
[EMAIL PROTECTED]
[Yet another batch of description tweaks, as well as the last major checkin of
translations to swedish (updated patch)
[EMAIL PROTECTED]
[Add missing include for sanity.c
[EMAIL PROTECTED]
[Remove the tokenize command from the rpm spec file
[EMAIL PROTECTED]
[Documentation corrections
[EMAIL PROTECTED]
[some little corrections
'Jan Fader <[EMAIL PROTECTED]>'**20060110174907]
[Make the read builtin able to create universal variables
[EMAIL PROTECTED]
[Remove the external tokenize command. One can use tr instead
[EMAIL PROTECTED]
[More minor completion description corrections, and another translation checkin
for Swedish
[EMAIL PROTECTED]
[Reload completions on locale language change. This will mean that most
translatable messages will be retranslated.
[EMAIL PROTECTED]
[Make command descriptions work when entering full path to a command
[EMAIL PROTECTED]
[Makecompletion functions work with completion descriptions regardless of if
they contain a separator character or not
[EMAIL PROTECTED]
[Do not free allocated data when clearing a string_buffer_t
[EMAIL PROTECTED]
[More robust parsing of keybindings, allow sequences like \C-\ew and \C-?
[EMAIL PROTECTED]
[Correct incorrect arguments to futimes
[EMAIL PROTECTED]
[Improve detection of futimes function, and make it fail without giving an
error message, since it is not critical anyways
[EMAIL PROTECTED]
[Documentation tweaks
[EMAIL PROTECTED]
[Minor completion description tweaks, try to use the same description for the
same situation in multiple commands, to decrease number of strings to translate
[EMAIL PROTECTED]
[Fix two issues on OS X, a non-compatible use of the expr command and a bad
init of a socket for the universal variable daemon
[EMAIL PROTECTED]
[Make description messages more uniform
[EMAIL PROTECTED]
[Improve locale implementation (should now behave identically to bash) and
document locale variables behaviour
[EMAIL PROTECTED]
[Huge upade containing several bugfixes related to i18n, and a huge number of
new translatable strings, including almost all description messages for command
specific completions
[EMAIL PROTECTED]
[Move definition of the _ gettext alias out of fish_interactive, since it is
needed in non-interactive, and in earlier functions as well
[EMAIL PROTECTED]
[Add more helpful error messages when trying to use Posix short circut
operators (|| and &&)
[EMAIL PROTECTED]
[Change syntax of 'and' and 'or' to infix order
[EMAIL PROTECTED]
[Do not use \r sequence in translatable messages
[EMAIL PROTECTED]
[Translate most shellscript output, translate internal completion descriptions,
and several translation bugfixes
[EMAIL PROTECTED]
[Improved description for the commandline builtin
[EMAIL PROTECTED]
[Output a message when changing LANG in interactive mode
[EMAIL PROTECTED]
[Further i18n tweaks
[EMAIL PROTECTED]
[Added a few notes to INSTALL file
[EMAIL PROTECTED]
[Minor fixes to i18n
[EMAIL PROTECTED]
[Add i18n through gettext, as well as a Swedish translation
[EMAIL PROTECTED]
[Minor text formating tweaks
[EMAIL PROTECTED]
[Add completions for nice and renice commands
[EMAIL PROTECTED]
[Pressing the enter key on an empty line scrolls a line
[EMAIL PROTECTED]
[TAG 1.19.0
[EMAIL PROTECTED]
Patch bundle hash:
3901e1d3e1bc8c46f32ef5a27266aa3cffd59b5c
pgpw6zIlDLVA4.pgp
Description: PGP signature
