On 9/17/06, Beni Cherniavsky <[EMAIL PROTECTED]> wrote: > On 15/09/06, Axel Liljencrantz <[EMAIL PROTECTED]> wrote: > > You don't need to forbid expansion to get ahead-of-time syntax > > checking. That is already what happens. > [...] > > Fish keeps track of commands which have not been given any arguments > > with parameter expansions, and validate more things in those cases. > > Duh, I should have checked before complaining. I feel like > contributing now. I went through the documentation of the builtins > and externals and made small improvements (darcs diff -u attached):
The patch is highly appriciated. I looked at the it and it seems to contain many much needed links and corrections. I'm very sorry to be a bother, but if it is possible, could you resend the patch as a darcs-style email bundle instead (Use the 'darcs send' subsommand). That makes it easier for me to apply the patch, since Darcs patches are much better at handling local changes I've made but not applied. Your identity as the originator of the patch is also preserved, which should give you a warm mushy feeling. :-) > > * Improved control structures synopsis consistency: > > * Rearanged [optional] brackets and semilcolons; so that commands like > ``else`` or ``end`` *always* follow semicolons (wasn't > consistently clear before). > > * I didn't show the facts that any commands list may be empty and that > the semicolon after commands like ``begin`` and ``else`` is optional - the > existing documentation doesn't show it and it'll only confuse users. > > BTW, the new ``end [what]`` behaivor is not documented yet. > I didn't bother since you expressed uncertainty whether to retain it. Indeed. > > * Clarified some behavior (e.g. while checks condition before command > and may never execute it) > > * Added some hints and see-alse links that I felt will help users > (e.g. bind -> commandline, Editor section; while -> begin, break). > > * Fixed couple of formatting errors (e.g. missing newline in > Description of nextd). > > * Cleared some source formatting that doesn't affect the output but is > more pleasant to edit (e.g. removed empty lines on top, tt+nbsp -> pre). Like I said above, these all look like great changes. > > ---- > > BTW, another micro-bug: things like 'break --help' don't run (outside > a loop => syntax error). That's OK, but it should then dump the help > anyway like some other syntax errors do (e.g. missing end). Absolutely. Surprisingly enough, this works for 'return', so this should just be a minor oversight. Thank you for the bug report. > > And about the recent discussion of not seeing help because bad browser > config: I think ``help help`` should always show help on the terminal; > at any rate ``help --help`` should do so like all other builtins when > given ``--help``. Right, that would be better. The problem is that 'help' is not a builtin, it is a plain shellscript function, just like vared, umask and type. I agree that it would be much nicer to have commandline --help-output for these functions, but that would require one to write some clever code to save away prerendered man-pages for these functions in separate files and display them on demand. Not very hard, but I haven't had time to do it yet. Patches are welcome! I am a strong beliver in using shellscript functions for anything that doesn't have to be a builtin in order to keep down the size of the codebase. Also, I imagine that this makes it easier to start contributing to fish, since one doesn't have to know C and learn all the gory details of how a shell works. > > -- > Beni Cherniavsky <[EMAIL PROTECTED]>, who can only read email on weekends. > > > -- Axel ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Fish-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fish-users
