On Sat, 16 Apr 2011 00:13:50 +0200 Carl-Daniel Hailfinger <[email protected]> wrote:
> We don't care about the memcpy (would be a micro-optimization and > those are almost always a bad idea). However, we care about good > debug and error messages. what does the first loop get us in respect to what you said? i would change the check_block_eraser method to return different values for "not suitable" and "not defined/no more methods" (there cant be holes in the eraser array, right?). i would then remove the first loop and just do checking and printing in the main loop. would you accept a patch for that or is there something i have missed? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
