Since it was sent out during the "dead archive" days, I'm re-sending the request to review/commit the patch. Since then, I got much more sure in its stability, as I'm flying with the rain enabled all the time, trying to select as nasty weather as possible :)
V. ---------- Forwarded message ---------- Date: Sun, 5 Mar 2006 00:31:25 +0200 (IST) From: Vassilii Khachaturov <[EMAIL PROTECTED]> To: flightgear-devel@lists.sourceforge.net Subject: Re: [Flightgear-devel] [PATCH] rain cone orientation On Fri, 3 Feb 2006, Vassilii Khachaturov wrote: > > > Rather, I wanted to make a subsection of preferences.xml dedicated to > > > precipitation rendering, maybe smth like a > > > /sim/rendering/precipitation > > > then just pass an sgprop node pointer from that environment manager > > > over to SGEnviro, and read properties inside SGEnviro from the subtree, > > > whenever I need that? > > > > > > Would that be a fine thing to do? > > > > Yep, that's how it's mostly done in SimGear and makes it easy to pass an > > increasing number of parameters without the need to alter the function > > call(s). > > Thanks a lot! Here comes the configurability patch, tested here with today's CVS. http://www.tarunz.org/~vassilii/fg/rain.diff Please review and apply if it's fine. Changes: 1) SimGear: * environment/visual_enviro.cxx now depends on props/props.hxx, which means additional link dependency when using libsgenvironment.a (fortunately the props are already linked in in the fgfs case!) * corrected the glRotatef() order in drawRain even further (a less obvious mistake than before, which is noticed by looking skywards and wiggling the mouse in the view direction change mode) * all the "magic numbers" used in the rain rendering code have been provided a default (based on the old hardcoded value) in a form of a define, and a meaningfully named static member in SGEnviro * SGEnviro::config() added to init the above according to defaults or config props * minor redundant gl call in DrawCone2 optimized away (twice per frame) * documented the change in the speed parameter meaning (leftover from the last patch) * more dox added along * minor spelling: s/familly/family/g 2) FlightGear/source: adding a call to SGEnviro::config to the FGEnvironmentMgr 3) FlightGear/data: an addition to preferences.xml, listing the current defaults (i.e., it'll work the same without this one applied, but is there for the docu. sake) ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
