James Turner wrote: > On 27 Dec 2008, at 08:16, Tim Moore wrote: > >> Modified Files: >> SGGeodesy.cxx >> Log Message: >> Fix include path > > <snip> > >> *** SGGeodesy.cxx 26 Dec 2008 12:08:28 -0000 1.8 >> --- SGGeodesy.cxx 27 Dec 2008 08:16:03 -0000 1.9 >> *************** >> *** 22,26 **** >> #include <cmath> >> >> ! #include "structure/exception.hxx" >> #include "SGMath.hxx" >> >> --- 22,26 ---- >> #include <cmath> >> >> ! #include <simgear/structure/exception.hxx> >> #include "SGMath.hxx" > > This is interesting - since we're in an implementation file, not a > public header, I regard my version as a 'better' choice than using a > system include, with the simgear prefix. Are you changing this for the > sake of style, consistency or correctness? (Or maybe all three :) Correctness, in the sense that I can't compile SimGear without this change. Also consistency, since in SimGear we consistently refer to headers from other SimGear modules using #include <simgear/...>. The important part of the change is adding "simgear" to the include path.
"<>" doesn't necessarily mean "public header", just (at least, in gcc) "look in standard places, including those added by -I." Tim ------------------------------------------------------------------------------ _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
