Hi All,
The current kx165 radio stack in Instruments-3D has a bug in it. Changing the
frequency after the decimal place by 0.025 using the left mouse button can
cause a carry to the integer part. e.g.
Decrementing 126.00 results in 125.97
Incrementing 126.97results in 127.00
I believe that the correct behaviour is as follows:
Decrementing 126.00 results in 126.97
Incrementing 126.97results in 126.00
The cause of this is some bug in the masking code controlling frequencies, but
the underlying problem is that the animation code isn't cut out for this sort
of work. John Denker has provided a patch that replaces the masking with a new
Nasal file (in Aircraft/Generic) for handling frequency changes. It's pretty
straightforward, and as a bonus, removes various repetitive constants, such as
the min/max frequencies.
The one minor downside is that using the mouse scroll wheel to change
frequencies is also affected, and no-longer changes the integer part of the
frequency. I don't intend to fix this, as the new behaviour is more realistic.
A future enhancement would be to provide separate scroll wheel pick animations
for the outer and inner frequency knobs, but I suspect that the pick animation
targets will then be too small to be usable.
I'd like to modify the kx165 in Aircraft/Instruments-3d/ to use this. However,
this requires that all aircraft using the instrument include a new .nas file
from Aircraft/Generic in their -set.xml file. I'm happy to make and test the
change, but I'd like permission from the various authors of the aircraft that
it affects.
>From a grep, the following aircraft are directly affected by this change:
SenecaII
Hansajet
c172p
If you are the maintainer of one of these aircraft, can you please let me know
if you are happy for me to go ahead with this.
The following aircraft have their own variation on the kx165, and so might want
to consider moving to the Instruments-3D version to benefit from this change:
pa24-250
c172p-dual-control (this isn't in CVS yet, and I know that Anders is planning
to work on making it compatible with Heiko's work on the c172p)
ZLT-NT
One this change has been made, I'm planning to make similar changes to the kr87
ADF frequency selector, which suffers from a similar problem, but has an even
more tangled set of users, and variations.
-Stuart
------------------------------------------------------------------------------
_______________________________________________
Flightgear-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
