> I've incorporated most of the comments made in the previous thread > Re: [Library] r7530-branches/branch-1.3/src/xutf8
Lovely. Though, as ever, I have even more comments... > I think that these, more straightforward, changes to mk_wcwidth.c > should now be portable across all platforms, unless someone has an > embedded system where sizeof(unsigned int) is less than 4. Yes. I think this is probably good enough... > Again, > it would be great if someone could confirm that the equivalent of > gcc -Wall -c src/xutf8/fl_wcwidth.c > compiles without problems on Windows and Mac. Fine on winXP with mingw. $ gcc -Wall -c src/xutf8/fl_wcwidth.c <nothing returned... So that is good> > If there are no more > issues, I will start looking into linking this into the build. Well... I still wonder if we need "src/xutf8/fl_wcwidth.c" at all? My preference would be to put that functionality into the existing file "src/fl_utf.c", which is kind of where I think it belongs anyway... In particular, that would mean that the fl_wcwidth() function would be able to take account of the macros (defined in "src/fl_utf.c") that define our utf8 error handling policy, in particular ERRORS_TO_CP1252 or STRICT_RFC3629. If we have ERRORS_TO_CP1252 set (it normally *is* set) in "src/fl_utf.c" then for the code points in the 0x80 to 0x9F range the fl_wcwidth() function would need to return (+1) whereas at present it will return (-1), which will not be what we want... Indications are that there's *a lot* of text out there that claims to be utf8 but actually uses that C1 control chars range (0x80 to 0x9F) as per the CP1252 characters, so we probably do want to do this. Thoughts? -- Ian SELEX Galileo Ltd Registered Office: Sigma House, Christopher Martin Road, Basildon, Essex SS14 3EL A company registered in England & Wales. Company no. 02426132 ******************************************************************** This email and any attachments are confidential to the intended recipient and may also be privileged. If you are not the intended recipient please delete it from your system and notify the sender. You should not copy it or use it for any purpose nor disclose or distribute its contents to any other person. ******************************************************************** _______________________________________________ fltk-dev mailing list fltk-dev@easysw.com http://lists.easysw.com/mailman/listinfo/fltk-dev
