On 10.11.2010, at 07:46, Duncan Gibson wrote: >> >> [STR Closed w/Resolution] >> >> Link: http://www.fltk.org/str.php?L2158 >> Version: 1.3-current >> Fix Version: 1.3.0 (r7812) >> >> >> Fixed in Subversion repository. >> >> >> Link: http://www.fltk.org/str.php?L2158 >> Version: 1.3-current >> Fix Version: 1.3.0 (r7812) >> > > Great work Matt, the code looks a lot cleaner than before, > but this STR ended up raising more issues that just wrap_mode. > > Are you sure this also addresses the "2 column" per CJK character > issue raised by Sparkaround? The previous commit didn't and I can't > see anything in the diff beyond colNum++. Shouldn't there also be a > call to fl_wcwidth()? > > And what about line breaking on other characters, and given in > fl_is_linebreak() in Timothy Lee's patch in another STR? > > Or do you intend to re-raise these as new STRs?
The line breaking issue already has a different STR #2162 IIRC. The line wrapping did get a new STR right away which will replace the current column based line wrapping with pixel based wrapping. It will remain compatible to the current IDE though. This will also solve the issue of any character width, no matter if 1, 2, or 1.8 columns of the nominal font width. Text_Display was never designed for proportional character set because it was a programmers editor. It needed quite some rework (as the diffs may have shown ;-). I decided for full proportional font support because limiting ourselves to 2-column CJK would have been almost the same amount of work, still leaving us with no support for proportional fonts. The current solution solves both. The main reason for closing this STR was to get the current critical STR out of the system. Please feel free to add new STRs if there are additional issues in the closed STR that need separate treatment. - Matthias _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
