Everything in the "pedals" branch works as expected. Thanks :)
-~Chris
On 6/4/21 1:21 PM, Ceresa Jean-Jacques wrote:
Hi, Christian
> I am hopeful that this change can be reverted, as I find it a
significant obstacle to rendering a proper live performance.
Please, could you try the branch named "pedals" to see if it works as
expected when sostenuto or sustain pedal is active.
See https://github.com/FluidSynth/fluidsynth/pull/905.
Thanks.
jjc
> Message du 04/06/21 14:19
> De : "Ceresa Jean-Jacques" <jean-jacques.cer...@orange.fr>
> A : "FluidSynthmailinglist" <fluid-dev@nongnu.org>
> Copie à :
> Objet : Re: [fluid-dev] repeating a note with the sustain pedal
active cuts off the previous note
>
>
> Hi Christian,
> I am the culprit author of "add sostenuto pedal functionality"
(David isn't responsible).
> Thanks for your interesting and detailled report of real
accoustic piano behaviour when playing the same note more than
once with the sustain or sustenuto pedal active.
>
> > I am hopeful that this change can be reverted, as I find it a
significant obstacle to rendering a proper live performance.
> I will look after this issue.
> jjc.
> Message du 04/06/21 00:47
> De : "S. Christian Collins" <s.chriscoll...@gmail.com>
> A : "FluidSynth Devel" <fluid-dev@nongnu.org>
> Copie à :
> Objet : [fluid-dev] repeating a note with the sustain pedal
active cuts off the previous note
>
>
> > Hi folks,
> > I have noticed in recent FluidSynth versions that when I
am playing any type of piano or keyboard sound, notes will
sometimes drop out unexpectedly. After a bit of
experimentation, I discovered what the problem is: when
playing the same note more than once with the sustain pedal
active, the previous note gets cut off. This is especially
noticeable if you play the note loudly and then softly; the
loud note just abruptly disappears. This did not happen in the
past when I was using an older FluidSynth version for live
performance with my band.
>
> > I was able to find the culprit by running a git bisect:
commit #048c51
<https://sourceforge.net/p/fluidsynth/code-git/ci/048c51c4ab55fc8bbf04816ff8b85c93fd238b5f/>
>
> >
------------------------------------------------------------------------------------
> Add sostenuto pedal functionality (ticket #47, #136)
> > Apart from adding sostenuto pedal functionality, this also
changes
> the behaviour of dampening currently sounding notes on the
same key
> to ignore pedals.
> > Signed-off-by: David Henningsson <diwic@...>
>
------------------------------------------------------------------------------------
>
> > Though the change to dampen currently sounding notes on
the same key with sustain/sostenuto was deliberate, I disagree
with this choice for the following reasons:
1. Real keyboard instruments do not behave in this manner.
With the sustain pedal depressed on a real piano, if you
play a note loudly and then very quietly, you still hear
the continued vibrations from the initial, loud keystroke.
2. All other MIDI GM-style devices I have encountered allow
previous notes on the same pitch to remain, including
those by Roland, Creative Labs/E-MU, and every other SF2
and SFZ sample player of any worth. AFAIK, FluidSynth
stands alone in the decision to mute older notes on the
same pitch by default.
>
> > Here are some audio examples so you can hear what I am
talking about. I have played the same patterns using:
1. A real piano (pedal notes-real piano.mp3
<https://drive.google.com/file/d/10vGke-ljIOVVi3YNx4cbjTsRMd9s1wPl/view?usp=sharing>)
2. FluidSynth prior to commit #048c51 (pedal
notes-FluidSynth-old.mp3
<https://drive.google.com/file/d/1bsAz1OO-QaXiF2dXG78pud6CavEIbvjk/view?usp=sharing>)
3. FluidSynth after commit #048c51 (pedal
notes-FluidSynth-new.mp3
<https://drive.google.com/file/d/1EtGwWgoY2JjfM8Zim__qHCYUYKvG3Mvm/view?usp=sharing>)
> > Each recording features the following patterns played with
the sustain pedal active, in order:
1. FF note followed by PP note.
2. FF note followed by MP note.
3. FF note followed by four notes increasing in velocity from
PP, and then repeating a few times.
>
> > Comparing the recordings, you can hear that the old
FluidSynth behavior matches that of the real piano, whereas
the new FluidSynth behavior is nothing alike. The MIDI file
for these patterns is attached to this e-mail for troubleshooting.
> > I am hopeful that this change can be reverted, as I find
it a significant obstacle to rendering a proper live
performance. It has implications with non-keyboard sounds as
well, but I didn't want to flood this e-mail with audio
examples, so I will only provide more examples if requested.
>
> > Thank you for your time :)
>
> > -~Chris
> >
>
_______________________________________________
fluid-dev mailing list
fluid-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/fluid-dev
>
> [ pedal notes test.mid (0.7 Ko) ]
_______________________________________________
fluid-dev mailing list
fluid-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/fluid-dev
_______________________________________________
fluid-dev mailing list
fluid-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/fluid-dev
_______________________________________________
fluid-dev mailing list
fluid-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/fluid-dev
