Hi Colin,
To answer the question - I haven't tested My Collection before my last
commit, which is mainly because I redirected the URLs to CouchDB, but
then before commit I introduced some small changes that didn't look too
harmful but proved to be at least time consuming to fix. I took the
opportunity to correct them and submitted a patch to the same issue you
attached your patch to:
http://issues.fluidproject.org/browse/ENGAGE-345
I managed to get the artifact view to work and the artifact collect view
to some extent. The main problem with the latter is that after rendering
the attempt to attach a handler to a DOM element found with jQuery.find
fails. However I'm short of ideas how to fix this as the collection
markup belongs logically inside the render scope. I've seen something
about "ignored" selectors being passed to the createRenderer function,
but here we are calling selfRender directly.
Two more notes:
- the artifact view should be accessed with an UUID parameter so that
its service can perform a check for the current status of the artifact
in the user collection. Maybe there is a better solution though.
- at the moment there are no CouchDB views in the users database, so I
was unable to test the My Collection page and see if I've tackled all
the problems. Maybe we should upload the original ones to see that the
view works and then change them as we spoke.
Regards,
Svetoslav
Colin Clark wrote:
I should also say that this is shaping up pretty nicely even if it's not quite
working properly yet. It'll be great to have this in the app, and I expect it
should be ready to go tomorrow.
Sveto, feel free to hack away at this patch if you want as well.
Colin
On 2010-02-08, at 8:44 PM, Colin Clark wrote:
It's getting late here and I haven't yet successfully integrated My Collection
into the application. It looks like there are a lot of little details scattered
throughout the code that is causing it to not actually function properly, even
in your branch. Have you been able to test it fully in the last week or so with
any success?
I'm going through systematically and addressing these issues while doing
minimal amounts of refactoring along the way. After this release, I can talk
you through a more comprehensive code review that I think can address a few
lingering design and implementation issues.
In the meantime, I've posted my not-quite-working changes to this JIRA ticket:
---
Colin Clark
Technical Lead, Fluid Project
http://fluidproject.org
_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work
