Hi Colin,
Good news is that My Collection is now working in my branch. The main
problem was that Lucene returned a different document from the one
returned by the other views and the model mapping wasn't working. To fix
this I added a pre-mapping in the collection service that is
transforming the document into the native couch view version.
Just one thing leftover that I wondered how to implement - when opening
the artifact page an user id should be passed as parameter "uuid" to
allow a correct assessment of the current state of the artifact in the
user collection.
Regards,
Svetoslav
Colin Clark wrote:
Hi again Sveto,
Another late night, and still no luck getting My Collection working. It really
does appear that the branch hasn't been functioning properly for a quite
awhile, so I've been trying to systematically peel back each issue one at a
time. I just committed a large number of fixes to the myCollection-tryout
branch.
I integrated a few of the fixes from your patch into my commit, but several of
the other changes weren't working. In particular, your changes to the path
segments weren't quite right. I can't shake the feeling that I'm missing
something here. There isn't some secret, more up to date My Collection branch
somewhere, is there?
Anyway, we're getting pretty close. The last lingering issue is documented
here, assuming I've understood the problem correctly:
http://issues.fluidproject.org/browse/ENGAGE-364
Can you take a look at this tomorrow and see if it makes sense to you? You may
also want to take a look at the views I set up for My Collection and see if
they're correct:
http://issues.fluidproject.org/browse/ENGAGE-346
My commit this evening was pretty substantial, so I recommend you take a look
through it to see what I've done. There are probably a few errors to catch, and
hopefully you'll pick up a few useful techniques too.
Colin
On 2010-02-09, at 8:59 AM, Svetoslav Nedkov wrote:
Hi Colin,
To answer the question - I haven't tested My Collection before my last commit,
which is mainly because I redirected the URLs to CouchDB, but then before
commit I introduced some small changes that didn't look too harmful but proved
to be at least time consuming to fix. I took the opportunity to correct them
and submitted a patch to the same issue you attached your patch to:
http://issues.fluidproject.org/browse/ENGAGE-345
I managed to get the artifact view to work and the artifact collect view to some extent.
The main problem with the latter is that after rendering the attempt to attach a handler
to a DOM element found with jQuery.find fails. However I'm short of ideas how to fix this
as the collection markup belongs logically inside the render scope. I've seen something
about "ignored" selectors being passed to the createRenderer function, but here
we are calling selfRender directly.
Two more notes:
- the artifact view should be accessed with an UUID parameter so that its
service can perform a check for the current status of the artifact in the user
collection. Maybe there is a better solution though.
- at the moment there are no CouchDB views in the users database, so I was
unable to test the My Collection page and see if I've tackled all the problems.
Maybe we should upload the original ones to see that the view works and then
change them as we spoke.
Regards,
Svetoslav
Colin Clark wrote:
I should also say that this is shaping up pretty nicely even if it's not quite
working properly yet. It'll be great to have this in the app, and I expect it
should be ready to go tomorrow.
Sveto, feel free to hack away at this patch if you want as well.
Colin
On 2010-02-08, at 8:44 PM, Colin Clark wrote:
It's getting late here and I haven't yet successfully integrated My Collection
into the application. It looks like there are a lot of little details scattered
throughout the code that is causing it to not actually function properly, even
in your branch. Have you been able to test it fully in the last week or so with
any success?
I'm going through systematically and addressing these issues while doing
minimal amounts of refactoring along the way. After this release, I can talk
you through a more comprehensive code review that I think can address a few
lingering design and implementation issues.
In the meantime, I've posted my not-quite-working changes to this JIRA ticket:
---
Colin Clark
Technical Lead, Fluid Project
http://fluidproject.org
---
Colin Clark
Technical Lead, Fluid Project
http://fluidproject.org
_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work
