Hi, Justin. It's an interesting idea, and would prepare us to explore things like migrating away from Grunt entirely, which myself and others have long talked about.
However, we don't just check things covered by ESlint. We have four or five other tasks, and I'm not sure there are ESlint plugins to replace all of them. I'd rather not support and have to reconcile two types of configuration if we can help it. For example, ESlint has rules about which files to include and exclude. Currently fluid-grunt-lint-all uses Grunt syntax for much of that, if we disallowed that for ESlint, do we still support it for everything else? Do we come up with our own JSON configuration file for everything else? Do we also support ESLint configuration within that file? Anyway, I think with a little discussion we can come up with answers to that and sketch out the work, then it's just a question of who can/should do it. Can you start us out by creating a ticket? Cheers, Tony On Mon, 28 Sep 2020 at 13:42, Justin Obara <obara.jus...@gmail.com> wrote: > Hi Tony, > > If it isn’t already possible, it might be easier for a user of > fluid-grunt-lint-all to be able to use the standard config files, e.g. > eslintrc.json to configure the settings of the various fluid-grunt-lint-all > plugins. IDEs can be setup to use these configuration files to provide > linting during coding/writing. Also, it may be clearer for those coming > into the project to understand what and where to find the configuration. > > Thanks > Justin > > On Sep 28, 2020, at 5:19 AM, Tony Atkins <t...@raisingthefloor.org> wrote: > > Hi, Cindy. > > When working on the plugin, I explicitly wanted to make sure that it was > possible to configure settings per project. As an example, here is the > test fixture I use to confirm that I can pass a custom configuration option > to each of the tasks that fluid-grunt-lint-all currently handles: > > > https://github.com/fluid-project/fluid-grunt-lint-all/blob/master/tests-Gruntfile-options-override.js > > I would expect for any new tasks such as CSS linting to also provide the > ability to configure new options per project. > > Cheers, > > > Tony > > On Fri, 25 Sep 2020 at 15:23, Cindy Li <c...@ocadu.ca> wrote: > >> One thought is, it might be helpful if fluid-grunt-lint-all could be >> flexible enough to allow the overriding of configurations, ideally for all >> linting tools it uses. >> >> One example is, most of our projects uses 4 spaces as indentations but at >> least WeCount project uses tabs as indentations. The switch to tabs is to >> allow developers to define their own preferred mapping from a tab to spaces >> in their IDEs, for the inclusion purpose. ;) >> >> Extending from it, individual projects may have their own linting >> requirements for their own reasons. It would be nice if fluid-grunt-lint-all >> could accommodate varied configurations. >> >> Thanks. >> >> Cindy >> >> On Sep 25, 2020, at 8:52 AM, Ned Zimmerman <nzimmer...@ocadu.ca> wrote: >> >> Thanks, Cindy. Having worked with the stylelint configuration on We >> Count, what are your thoughts? Are there any changes you'd recommend? >> >> Cheers, >> Ned >> — >> Ned Zimmerman (he/him) >> Senior Inclusive Developer >> Inclusive Design Research Centre, OCAD University >> https://idrc.ocadu.ca >> >> On 2020-09-25, 9:26 AM, "Cindy Li" <c...@ocadu.ca> wrote: >> >> Great idea. +1 >> >> On Sep 24, 2020, at 10:42 AM, Ned Zimmerman <nzimmer...@ocadu.ca> wrote: >> >> Hi all, >> >> I wanted to propose that we create a shareable Stylelint configuration >> for Fluid projects along the lines of eslint-config-fluid. This could be >> added to fluid-grunt-lint-all and used as a starting point in various >> projects. Stylelint is currently in use in the new IDRC website and in the >> We Count website. I created a JIRA for this (FLUID-6555) and there are some >> relevant links there. Eager to hear others' thoughts on this and I'm happy >> to start working on it if it sounds like a good idea to others. >> >> Cheers, >> Ned >> — >> Ned Zimmerman (he/him) >> Senior Inclusive Developer >> Inclusive Design Research Centre, OCAD University >> https://idrc.ocadu.ca >> >> _______________________________________________________ >> fluid-work mailing list - fluid-work@lists.idrc.ocad.ca >> To unsubscribe, change settings or access archives, >> see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work >> >> >> >> >> _______________________________________________________ >> fluid-work mailing list - fluid-work@lists.idrc.ocad.ca >> To unsubscribe, change settings or access archives, >> see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work > > _______________________________________________________ > fluid-work mailing list - fluid-work@lists.idrc.ocad.ca > To unsubscribe, change settings or access archives, > see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work > > >
_______________________________________________________ fluid-work mailing list - fluid-work@lists.idrc.ocad.ca To unsubscribe, change settings or access archives, see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work
