-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3359/
-----------------------------------------------------------
(Updated 2012-01-04 02:45:47.788788)
Review request for Flume.
Changes
-------
o.a.flume.event . SourceEventHandler and SinkEventHandler added.
Default implementation of SinkEventHandler - AvroSourceProtocolSinkHandler
implemented.
AvroSource: Separation of management of resources and reference implementation
of AvroSourceProtocol .
New class - AvroSourceProtocolImpl , implements the same.
Summary
-------
AvroSource / AvroSink made abstract, that are agnostic of the Avro object used
for transport or the interchange between Avro objects and the Flume 'Event's
and 'Channel's for communication.
DefaultAvroSource / DefaultAvroSink in place to preserve existing behavior.
Custom Avro transports can inherit from AvroSource / AvroSink-s , to override
the methods.
This addresses bug FLUME-918.
https://issues.apache.org/jira/browse/FLUME-918
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/event/SinkEventHandler.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/event/SourceEventHandler.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java
1226957
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
1226957
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSourceProtocolSinkHandler.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java
1226957
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSourceProtocolImpl.java
PRE-CREATION
Diff: https://reviews.apache.org/r/3359/diff
Testing
-------
Thanks,
Karthik