----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3359/ -----------------------------------------------------------
(Updated 2012-01-19 20:37:02.912881)
Review request for Flume.
Changes
-------
Revised patch attached that takes out the transaction semantics out of
avrosource, and makes it generic. New class - TransactionManager introduced
with the semantics.
Summary
-------
AvroSource / AvroSink concrete classes has injectible eventHandlers
(SourceEventHandler and SinkEventHandler), to allow for diffrerent avro
protocols to be sent over flume NG. ( not restricted to AvroSourceProtocol ,
as it stands today).
Default implementation refers to AvroSourceProtocol still though.
This addresses bug FLUME-918.
https://issues.apache.org/jira/browse/FLUME-918
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/event/SinkEventHandler.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/event/SourceEventHandler.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java
1233531
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
1233531
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSourceProtocolSinkHandler.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java
1233531
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSourceProtocolImpl.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/TransactionManager.java
PRE-CREATION
Diff: https://reviews.apache.org/r/3359/diff
Testing
-------
Thanks,
Karthik
