----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3505/#review4406 -----------------------------------------------------------
Thanks a lot for the review. I will update the patch with your comments addressed. - Bruno On 2012-01-14 05:47:18, Bruno Mahé wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3505/ > ----------------------------------------------------------- > > (Updated 2012-01-14 05:47:18) > > > Review request for Flume. > > > Summary > ------- > > Add an implementation for a JMS sink > > > This addresses bug FLUME-923. > https://issues.apache.org/jira/browse/FLUME-923 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 5be602a > flume-ng-dist/pom.xml 5c20252 > flume-ng-node/pom.xml c0e295c > flume-ng-sinks/flume-jms-sink/pom.xml PRE-CREATION > > flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java > PRE-CREATION > > flume-ng-sinks/flume-jms-sink/src/test/java/org/apache/flume/sink/jms/TestJMSSink.java > PRE-CREATION > flume-ng-sinks/pom.xml 044bf8e > pom.xml 6002358 > > Diff: https://reviews.apache.org/r/3505/diff > > > Testing > ------- > > * Checked unit tests pass, including the one from the JMS sink > * Brought up my own external JMS broker and hooked up a JMS sink on a flume > node > > > Thanks, > > Bruno > >
