----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3505/#review4704 -----------------------------------------------------------
Thanks for the patch Bruno. I want to take a look at the complete set of changes together but for some reason I am unable to do it. Probably because use have used the parent-diff approach to incrementally add changes. Can you please create a fresh diff and upload it to the review board without linking it with the previous parent diff? Thanks - Arvind On 2012-01-19 03:20:24, Bruno Mahé wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3505/ > ----------------------------------------------------------- > > (Updated 2012-01-19 03:20:24) > > > Review request for Flume. > > > Summary > ------- > > Add an implementation for a JMS sink > > > This addresses bug FLUME-923. > https://issues.apache.org/jira/browse/FLUME-923 > > > Diffs > ----- > > > flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3505/diff > > > Testing > ------- > > * Checked unit tests pass, including the one from the JMS sink > * Brought up my own external JMS broker and hooked up a JMS sink on a flume > node > > > Thanks, > > Bruno > >
