[
https://issues.apache.org/jira/browse/FLUME-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193509#comment-13193509
]
[email protected] commented on FLUME-937:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3599/#review4618
-----------------------------------------------------------
Ship it!
Hey Prasad, mostly nits / comment requests for more 'whys' in code. Please add
and feel free tocommit.
Which tests failed? If require significant changes, please resubmit. If they
are minor, this essentially lgtm.
flume-core/pom.xml
<https://reviews.apache.org/r/3599/#comment10276>
Is here a reason why there is only one profile here but 2 in the other?
as a non-maven expert, is any way to consolidate the two (i thought the
subprojects can inherit properties.)
flume-core/pom.xml
<https://reviews.apache.org/r/3599/#comment10273>
nit: indents
flume-core/src/main/java/com/cloudera/flume/handlers/hdfs/SeqfileEventSink.java
<https://reviews.apache.org/r/3599/#comment10277>
This is wonky code -- I can understand why it is needed with the context of
the JIRA but without it I can't tell. Can you add comments about why this is
necessary and a reference to FLUME-937? This seems to be the right place to
explain it.
flume-core/src/main/java/com/cloudera/flume/handlers/hdfs/SeqfileEventSink.java
<https://reviews.apache.org/r/3599/#comment10278>
nit: extra lines.
pom.xml
<https://reviews.apache.org/r/3599/#comment10274>
File an issue to make compile against apache 1.0.0 hadoop?
pom.xml
<https://reviews.apache.org/r/3599/#comment10275>
File an issue to make it compile against apache hadoop 0.23.0?
pom.xml
<https://reviews.apache.org/r/3599/#comment10272>
nit: indents
- jmhsieh
On 2012-01-24 07:12:54, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3599/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-24 07:12:54)
bq.
bq.
bq. Review request for Bruno Mahé and jmhsieh.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. 1. Add new maven profile to compile with Hadoop 0.23
bq. 2. Exclude the variants of sequence file which are not compiling with 0.23
bq. 3. Replace the deprecated HDFS interface (getCompressionType)
bq.
bq.
bq. This addresses bug Flume-937.
bq. https://issues.apache.org/jira/browse/Flume-937
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-core/pom.xml 4a09812
bq.
flume-core/src/main/java/com/cloudera/flume/handlers/hdfs/SeqfileEventSink.java
b88c292
bq.
flume-core/src/main/java/com/cloudera/flume/handlers/seqfile/SequenceFileOutputFormat.java
e6d321f
bq.
flume-core/src/test/java/com/cloudera/flume/agent/durability/TestNaiveFileWALManager.java
ce42c37
bq. pom.xml 1ac9aaa
bq.
bq. Diff: https://reviews.apache.org/r/3599/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Full test run.
bq. Still have two failures, one is intermittent and other looks like hadoop
bug. will complete the analysis.
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Make Flume compile against Hadoop 0.23
> --------------------------------------
>
> Key: FLUME-937
> URL: https://issues.apache.org/jira/browse/FLUME-937
> Project: Flume
> Issue Type: Improvement
> Components: Build, Sinks+Sources
> Affects Versions: v0.9.5
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v0.9.5
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
