[
https://issues.apache.org/jira/browse/FLUME-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197052#comment-13197052
]
[email protected] commented on FLUME-937:
-----------------------------------------------------
bq. On 2012-01-26 01:33:14, jmhsieh wrote:
bq. > Hey Prasad, mostly nits / comment requests for more 'whys' in code.
Please add and feel free tocommit.
bq. >
bq. > Which tests failed? If require significant changes, please resubmit.
If they are minor, this essentially lgtm.
Thanks for the review Jon !
Addressed the space/indentation nits
Updated the pom to pickup the hadoop dependencies from apache repo
added comments in SeqfileEventSink.java
The failed test seems to be a 0.23 bug, I will go ahead and log a jira and also
one for hadoop 1.0 compilation.
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3599/#review4618
-----------------------------------------------------------
On 2012-01-24 07:12:54, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3599/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-24 07:12:54)
bq.
bq.
bq. Review request for Bruno Mahé and jmhsieh.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. 1. Add new maven profile to compile with Hadoop 0.23
bq. 2. Exclude the variants of sequence file which are not compiling with 0.23
bq. 3. Replace the deprecated HDFS interface (getCompressionType)
bq.
bq.
bq. This addresses bug Flume-937.
bq. https://issues.apache.org/jira/browse/Flume-937
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-core/pom.xml 4a09812
bq.
flume-core/src/main/java/com/cloudera/flume/handlers/hdfs/SeqfileEventSink.java
b88c292
bq.
flume-core/src/main/java/com/cloudera/flume/handlers/seqfile/SequenceFileOutputFormat.java
e6d321f
bq.
flume-core/src/test/java/com/cloudera/flume/agent/durability/TestNaiveFileWALManager.java
ce42c37
bq. pom.xml 1ac9aaa
bq.
bq. Diff: https://reviews.apache.org/r/3599/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Full test run.
bq. Still have two failures, one is intermittent and other looks like hadoop
bug. will complete the analysis.
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Make Flume compile against Hadoop 0.23
> --------------------------------------
>
> Key: FLUME-937
> URL: https://issues.apache.org/jira/browse/FLUME-937
> Project: Flume
> Issue Type: Improvement
> Components: Build, Sinks+Sources
> Affects Versions: v0.9.5
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v0.9.5
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
