[
https://issues.apache.org/jira/browse/FLUME-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206460#comment-13206460
]
[email protected] commented on FLUME-964:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3876/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Attached patch removes all compiler warnings except:
1) Where someone is not implemented and unused variables will be used
2) Where the source is generated (thrift)
This addresses bug FLUME-964.
https://issues.apache.org/jira/browse/FLUME-964
Diffs
-----
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannelException.java
c7078e6
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java
fe6a36d
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcTransactionFactory.java
b49f500
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/PersistableEvent.java
36c3381
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java
4c94c4b
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
d379b64
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java
398ee61
flume-ng-core/src/main/java/org/apache/flume/channel/PseudoTxnMemoryChannel.java
e0342d7
flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java
9fb6dff
flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 3808d5d
flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 3af1bb0
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 351141b
flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
648d757
flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java
5d127eb
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
46e42e3
flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java
b458b36
flume-ng-legacy-sources/flume-avro-source/src/test/java/org/apache/flume/source/avroLegacy/TestLegacyAvroSource.java
bd2b396
flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
7a6c09b
Diff: https://reviews.apache.org/r/3876/diff
Testing
-------
Unit tests passed.
Thanks,
Brock
> Remove compiler warnings where possible
> ---------------------------------------
>
> Key: FLUME-964
> URL: https://issues.apache.org/jira/browse/FLUME-964
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Affects Versions: v1.0.0
> Reporter: Brock Noland
>
> FlumeNG has a number of compiler warnings we can be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
