[
https://issues.apache.org/jira/browse/FLUME-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206601#comment-13206601
]
[email protected] commented on FLUME-964:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3876/#review5038
-----------------------------------------------------------
Ship it!
Changes look good Brock! One minor comment below.
flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
<https://reviews.apache.org/r/3876/#comment11067>
Please use Map<CharSequence, CharSequence> instead of HashMap<>.
- Arvind
On 2012-02-12 17:58:07, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3876/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-12 17:58:07)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Attached patch removes all compiler warnings except:
bq.
bq. 1) Where someone is not implemented and unused variables will be used
bq. 2) Where the source is generated (thrift)
bq.
bq.
bq. This addresses bug FLUME-964.
bq. https://issues.apache.org/jira/browse/FLUME-964
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannelException.java
c7078e6
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java
fe6a36d
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcTransactionFactory.java
b49f500
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/PersistableEvent.java
36c3381
bq.
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java
4c94c4b
bq. flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
d379b64
bq.
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java
398ee61
bq.
flume-ng-core/src/main/java/org/apache/flume/channel/PseudoTxnMemoryChannel.java
e0342d7
bq.
flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java
9fb6dff
bq. flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 3808d5d
bq. flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java
3af1bb0
bq. flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java
351141b
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
648d757
bq.
flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java
5d127eb
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
46e42e3
bq.
flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java
b458b36
bq.
flume-ng-legacy-sources/flume-avro-source/src/test/java/org/apache/flume/source/avroLegacy/TestLegacyAvroSource.java
bd2b396
bq.
flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
7a6c09b
bq.
bq. Diff: https://reviews.apache.org/r/3876/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> Remove compiler warnings where possible
> ---------------------------------------
>
> Key: FLUME-964
> URL: https://issues.apache.org/jira/browse/FLUME-964
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Attachments: FLUME-964-0.patch, FLUME-964-0.patch
>
>
> FlumeNG has a number of compiler warnings we can be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
