[ 
https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211860#comment-13211860
 ] 

[email protected] commented on FLUME-979:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3962/
-----------------------------------------------------------

(Updated 2012-02-20 14:21:02.192435)


Review request for Flume.


Changes
-------

Added note about reading stderr of a sub-process is required.


Summary (updated)
-------

1) Allows users to configure a restart flag and sleep interval for the 
ExecSource should the command exit.
2) Currently no one is reading standard error for the sub process. It is not 
ignored like the documentation suggests. If the command generates enough stderr 
to fill it's buffer, it will be blocked until someone reads that buffer. A 
thread is added which by default reads and throws away stderr. If a flag is 
turned on it will logstderr. This kind of flag can be very useful when 
debugging why a command is not outputting the expected data.


This addresses bug FLUME-979.
    https://issues.apache.org/jira/browse/FLUME-979


Diffs
-----

  flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 
3014368 
  flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java a96016c 

Diff: https://reviews.apache.org/r/3962/diff


Testing
-------

A test for the restart flag and restartThrottle flag were added. All unit tests 
pass.


Thanks,

Brock


                
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
>                 Key: FLUME-979
>                 URL: https://issues.apache.org/jira/browse/FLUME-979
>             Project: Flume
>          Issue Type: Improvement
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: FLUME-979-0.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops 
> emitting events.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to