[
https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234048#comment-13234048
]
[email protected] commented on FLUME-979:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3962/#review6159
-----------------------------------------------------------
Changes look good Brock. Some minor feedback:
* Please remove the extra whitespaces/tabs that are highlighted as red on the
review
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java
<https://reviews.apache.org/r/3962/#comment13244>
Please create a ExecSourceConfigurationConstants class and declare these
strings as public static final String CONFIG_RESTART_THROTTLE etc.
The patch will also need to be rebased on the trunk as the sources have changed
a bit since the last time.
- Arvind
On 2012-02-20 14:21:02, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3962/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-20 14:21:02)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. 1) Allows users to configure a restart flag and sleep interval for the
ExecSource should the command exit.
bq. 2) Currently no one is reading standard error for the sub process. It is
not ignored like the documentation suggests. If the command generates enough
stderr to fill it's buffer, it will be blocked until someone reads that buffer.
A thread is added which by default reads and throws away stderr. If a flag is
turned on it will logstderr. This kind of flag can be very useful when
debugging why a command is not outputting the expected data.
bq.
bq.
bq. This addresses bug FLUME-979.
bq. https://issues.apache.org/jira/browse/FLUME-979
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
3014368
bq. flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java
a96016c
bq.
bq. Diff: https://reviews.apache.org/r/3962/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. A test for the restart flag and restartThrottle flag were added. All unit
tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops
> emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
