All:

I just checked out Flume and the build is broken. The hudson job seems to
be largely ignored. I want to stress that code reviews aren't just for
show; we should actually review the code. Some classes were removed (I
don't necessarily think it was a great idea, but that's another story) and
tests weren't updated and now they fail to compile. What bugs me more is
that this happend about 5 commits ago which means people aren't running the
tests at all nor are they validating the patches they commit.

If you make a change to the code base and you only run the tests you care
about, you're defeating one of the main purposes of unit testing; to ensure
there are no unintended consequences of the changes.

Please be vigilant. People trust their data to Flume and we shouldn't take
that lightly. It's critical that with all the new committers joining the
project and the pace of development that we not go feature crazy and get
right back to where the 0.9.x branch was. I will continue to be a pain the
ass about this. :)

Thanks.
-- 
Eric Sammer
twitter: esammer
data: www.cloudera.com

Reply via email to