-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4360/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

This is an initial pass at an implementation of HDFS security. I think it will 
probably work. Currently trying to get Kerberos to play nice with the cluster 
on my VM though, so I haven't successfully tested it yet. It still works when 
used on HDFS with security disabled. :)

The only thing I don't like is in configure() when authentication fails I throw 
a FlumeException. I'll trace up and see how bad that would be but it seems 
likely to break something. Just logging the error is kind of a bummer as well, 
though ... need to ensure process() doesn't fill up the disk while spewing 
copious error messages into the logs. Maybe this is a use case for some kind of 
FatalException type thing.


This addresses bug FLUME-1020.
    https://issues.apache.org/jira/browse/FLUME-1020


Diffs
-----

  
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
 da82f7e 

Diff: https://reviews.apache.org/r/4360/diff


Testing
-------


Thanks,

Mike

Reply via email to