----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4360/#review6166 -----------------------------------------------------------
bin/flume-ng <https://reviews.apache.org/r/4360/#comment13279> Should we also try the bigtop autodetect script? http://svn.apache.org/repos/asf/incubator/bigtop/trunk/bigtop-packages/src/common/bigtop-utils/bigtop-detect-javahome This script: http://svn.apache.org/repos/asf/incubator/bigtop/trunk/bigtop-packages/src/common/hadoop/install_hadoop.sh calls the script as follows: # Autodetect JAVA_HOME if not defined if [ -e /usr/libexec/bigtop-detect-javahome ]; then . /usr/libexec/bigtop-detect-javahome elif [ -e /usr/lib/bigtop-utils/bigtop-detect-javahome ]; then . /usr/lib/bigtop-utils/bigtop-detect-javahome fi flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java <https://reviews.apache.org/r/4360/#comment13277> The only place this method is called we have previously checked to see if security is enabled. Why do this check in both places? flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java <https://reviews.apache.org/r/4360/#comment13278> This is good debug info. But if it fails here, we have already logged in. Should we be returning false? - Brock On 2012-03-20 22:33:43, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4360/ > ----------------------------------------------------------- > > (Updated 2012-03-20 22:33:43) > > > Review request for Flume. > > > Summary > ------- > > This is an initial pass at an implementation of HDFS security. I think it > will probably work. Currently trying to get Kerberos to play nice with the > cluster on my VM though, so I haven't successfully tested it yet. It still > works when used on HDFS with security disabled. :) > > The only thing I don't like is in configure() when authentication fails I > throw a FlumeException. I'll trace up and see how bad that would be but it > seems likely to break something. Just logging the error is kind of a bummer > as well, though ... need to ensure process() doesn't fill up the disk while > spewing copious error messages into the logs. Maybe this is a use case for > some kind of FatalException type thing. > > > This addresses bug FLUME-1020. > https://issues.apache.org/jira/browse/FLUME-1020 > > > Diffs > ----- > > bin/flume-ng 0796a5b > flume-ng-sinks/flume-hdfs-sink/pom.xml 1a35baf > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > da82f7e > > Diff: https://reviews.apache.org/r/4360/diff > > > Testing > ------- > > > Thanks, > > Mike > >
