[ 
https://issues.apache.org/jira/browse/FLUME-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230589#comment-13230589
 ] 

[email protected] commented on FLUME-1032:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4368/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Fixing various build issues:

1. Maven build against Hadoop 0.23 is misconfigured:
  - Referenced Hadoop artifact (0.23-SNAPSHOT) does not exist in central repo 
(build fails due to this)
  - slf4j-jcl gets pulled in, which breaks logging at runtime due to the 
inclusion of slf4j-log4j12 as well
  - downstream dependencies which should be transitively included are 
explicitly referenced only for hadoop-0.23 (commons-logging and 
commons-configuration)
  - hadoop-hdfs jar is missing
  (I think much of this was broken-build stuff in the SNAPSHOT which was fixed 
for release)

2. Several artifacts are missing from the -dist archive:
  - SDK jar
  - Legacy sources
  - log4j appender client


This addresses bug FLUME-1032.
    https://issues.apache.org/jira/browse/FLUME-1032


Diffs
-----

  flume-ng-clients/flume-ng-log4jappender/pom.xml d1c443d 
  flume-ng-dist/pom.xml f7e0dd9 
  flume-ng-dist/src/main/assembly/dist.xml afe7a44 
  flume-ng-dist/src/main/assembly/src.xml 21278dc 
  flume-ng-sinks/flume-hdfs-sink/pom.xml 76d69a3 
  pom.xml cf10727 

Diff: https://reviews.apache.org/r/4368/diff


Testing
-------

Tested 3 profiles: default (hadoop-0.20.205), -Dhadoop.profile=100 
(hadoop-1.0.0), -Dhadoop.profile=23 (hadoop-0.23)


Thanks,

Mike


                
> Fix / clean up Flume NG build
> -----------------------------
>
>                 Key: FLUME-1032
>                 URL: https://issues.apache.org/jira/browse/FLUME-1032
>             Project: Flume
>          Issue Type: Improvement
>            Reporter: Mike Percy
>            Assignee: Mike Percy
>
> There are problems with the current Flume NG maven build setup:
> 1. Maven build against Hadoop 0.23 is misconfigured:
>    - Referenced Hadoop artifact does not exist in central repo (build fails 
> due to this)
>    - commons-logging gets pulled in, which causes slf4j errors at Flume 
> runtime due to multiple logger implementations (commons & log4j)
> 2. Several artifacts are missing from the -dist archive:
>    - SDK jar
>    - Legacy sources
>    - log4j appender client
> Patch forthcoming to address these issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to