[
https://issues.apache.org/jira/browse/FLUME-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232888#comment-13232888
]
[email protected] commented on FLUME-1032:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4368/#review6080
-----------------------------------------------------------
Ship it!
Looks good to me.
- Andrew
On 2012-03-15 21:42:49, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4368/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 21:42:49)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Fixing various build issues:
bq.
bq. 1. Maven build against Hadoop 0.23 is misconfigured:
bq. - Referenced Hadoop artifact (0.23-SNAPSHOT) does not exist in central
repo (build fails due to this)
bq. - slf4j-jcl gets pulled in, which breaks logging at runtime due to the
inclusion of slf4j-log4j12 as well
bq. - downstream dependencies which should be transitively included are
explicitly referenced only for hadoop-0.23 (commons-logging and
commons-configuration)
bq. - hadoop-hdfs jar is missing
bq. (I think much of this was broken-build stuff in the SNAPSHOT which was
fixed for release)
bq.
bq. 2. Several artifacts are missing from the -dist archive:
bq. - SDK jar
bq. - Legacy sources
bq. - log4j appender client
bq.
bq.
bq. This addresses bug FLUME-1032.
bq. https://issues.apache.org/jira/browse/FLUME-1032
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-clients/flume-ng-log4jappender/pom.xml d1c443d
bq. flume-ng-dist/pom.xml f7e0dd9
bq. flume-ng-dist/src/main/assembly/dist.xml afe7a44
bq. flume-ng-dist/src/main/assembly/src.xml 21278dc
bq. flume-ng-sinks/flume-hdfs-sink/pom.xml 76d69a3
bq. pom.xml cf10727
bq.
bq. Diff: https://reviews.apache.org/r/4368/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested 3 profiles: default (hadoop-0.20.205), -Dhadoop.profile=100
(hadoop-1.0.0), -Dhadoop.profile=23 (hadoop-0.23)
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> Fix / clean up Flume NG build
> -----------------------------
>
> Key: FLUME-1032
> URL: https://issues.apache.org/jira/browse/FLUME-1032
> Project: Flume
> Issue Type: Improvement
> Reporter: Mike Percy
> Assignee: Mike Percy
>
> There are problems with the current Flume NG maven build setup:
> 1. Maven build against Hadoop 0.23 is misconfigured:
> - Referenced Hadoop artifact does not exist in central repo (build fails
> due to this)
> - commons-logging gets pulled in, which causes slf4j errors at Flume
> runtime due to multiple logger implementations (commons & log4j)
> 2. Several artifacts are missing from the -dist archive:
> - SDK jar
> - Legacy sources
> - log4j appender client
> Patch forthcoming to address these issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
