> On 2012-04-07 12:35:09, Will McQueen wrote: > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, > > line 27 > > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line27> > > > > for readability: > > SYSPRO=>SYSPROP > > (here and in all referenced locations)
done. > On 2012-04-07 12:35:09, Will McQueen wrote: > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, > > line 33 > > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line33> > > > > SYSPRO=>SYSPROP done. > On 2012-04-07 12:35:09, Will McQueen wrote: > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, > > line 69 > > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line69> > > > > For readability: > > PROPERTIES=>PROPS > > (here and all referring locations) done. > On 2012-04-07 12:35:09, Will McQueen wrote: > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, > > line 75 > > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line75> > > > > PROPERTIES=>PROPS done. > On 2012-04-07 12:35:09, Will McQueen wrote: > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, > > line 121 > > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line121> > > > > For readability: > > CONNECTION=>CONNECTIONS > > ...here and in all referring locations done. > On 2012-04-07 12:35:09, Will McQueen wrote: > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, > > line 126 > > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line126> > > > > CONNECTION=>CONNECTIONS done. > On 2012-04-07 12:35:09, Will McQueen wrote: > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, > > line 542 > > <https://reviews.apache.org/r/4677/diff/1/?file=100846#file100846line542> > > > > Long=>long > > new form => new short form done. > On 2012-04-07 12:35:09, Will McQueen wrote: > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, > > line 550 > > <https://reviews.apache.org/r/4677/diff/1/?file=100846#file100846line550> > > > > @param defaultValue default value, null if no default done. - Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/#review6768 ----------------------------------------------------------- On 2012-04-07 08:32:03, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4677/ > ----------------------------------------------------------- > > (Updated 2012-04-07 08:32:03) > > > Review request for Flume. > > > Summary > ------- > > Modified the implementation to deprecate the old form of configuration keys > for JDBC channel. The new form takes precedence if both types are present. > > > This addresses bug FLUME-1107. > https://issues.apache.org/jira/browse/FLUME-1107 > > > Diffs > ----- > > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java > 1310683 > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java > 1310683 > > Diff: https://reviews.apache.org/r/4677/diff > > > Testing > ------- > > Ran JDBC channel unit tests with the deprecated old form of configuration > keys. Updated the tests to use the new form and tested as well. > > > Thanks, > > Arvind > >
