-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4677/
-----------------------------------------------------------
(Updated 2012-04-07 20:01:51.619038)
Review request for Flume.
Changes
-------
Thanks for the review Will. I have incorporated your suggestions.
Summary
-------
Modified the implementation to deprecate the old form of configuration keys for
JDBC channel. The new form takes precedence if both types are present.
This addresses bug FLUME-1107.
https://issues.apache.org/jira/browse/FLUME-1107
Diffs (updated)
-----
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
1310683
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
1310683
/trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java
1310683
Diff: https://reviews.apache.org/r/4677/diff
Testing
-------
Ran JDBC channel unit tests with the deprecated old form of configuration keys.
Updated the tests to use the new form and tested as well.
Thanks,
Arvind
