-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4681/
-----------------------------------------------------------

Review request for Flume and Arvind Prabhakar.


Summary
-------

The sink runner's stop method first calls stop() to underlying sink and then 
shuts down the PollingRunner thread. If that thread is in middle of process, it 
leads to race conditions in the sink's process() and stop().
Rather than making all sinks to handle concurrently process() and stop(), its 
safer to shutdown the runner thread first and then stop the sink.


This addresses bug FLUME-1110.
    https://issues.apache.org/jira/browse/FLUME-1110


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java e73c09b 

Diff: https://reviews.apache.org/r/4681/diff


Testing
-------

full regression test run


Thanks,

Prasad

Reply via email to